Browse Source

Don't assume an event's userfulness when showing logs

release-2.9
Jean-Romain Garnier 6 years ago
committed by Gabriel Detraz
parent
commit
125ffbbd23
  1. 6
      logs/models.py

6
logs/models.py

@ -421,11 +421,6 @@ class VersionAction(HistoryEvent):
def __init__(self, version): def __init__(self, version):
self.version = version self.version = version
def is_useful(self):
# Some versions are duplicates, and don't have a reference
# to any object, so ignore them
return self.version.object_id is not None
def name(self): def name(self):
return "{} {}".format(self.model_name().title(), self.version.object_repr) return "{} {}".format(self.model_name().title(), self.version.object_repr)
@ -490,7 +485,6 @@ class RevisionAction:
self.performed_by = revision.user self.performed_by = revision.user
self.revision = revision self.revision = revision
self.versions = [VersionAction(v) for v in revision.version_set.all()] self.versions = [VersionAction(v) for v in revision.version_set.all()]
self.versions = filter(lambda v: v.is_useful(), self.versions)
def id(self): def id(self):
return self.revision.id return self.revision.id

Loading…
Cancel
Save